fluencelabs/musl
1
0
Fork 0
mirror of https://github.com/fluencelabs/musl synced 2025-06-24 12:12:04 +00:00
Code Issues Projects Releases Wiki Activity

fix logic error in fread

Browse Source 
fread was calling f->read without checking that the file was in
reading mode. this could:
1. crash, if f->read was a null pointer
2. cause unwanted blocking on a terminal already at eof
3. allow reading on a write-only file
This commit is contained in:
Rich Felker
2011-07-16 21:24:02 -04:00
parent 47d027ee1a
commit 94a0171d80
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/stdio/fread.c
View File

@ -21,14 +21,9 @@ size_t fread(void *destv, size_t size, size_t nmemb, FILE *f)
l -= k; l -= k;
} }
if (!l) {
FUNLOCK(f);
return nmemb;
}
/* Read the remainder directly */ /* Read the remainder directly */
for (; l; l-=k, dest+=k) { for (; l; l-=k, dest+=k) {
k = f->read(f, dest, l); k = __toread(f) ? 0 : f->read(f, dest, l);
if (k+1<=1) { if (k+1<=1) {
FUNLOCK(f); FUNLOCK(f);
return (len-l)/size; return (len-l)/size;