fluencelabs/musl
1
0
Fork 0
mirror of https://github.com/fluencelabs/musl synced 2025-06-30 15:11:55 +00:00
Code Issues Projects Releases Wiki Activity

eliminate use of SHARED macro to suppress visibility attributes

Browse Source 
this is the first and simplest stage of removal of the SHARED macro,
which will eventually allow libc.a and libc.so to be produced from the
same object files.

the original motivation for these #ifdefs which are now being removed
was to allow building a static-only libc using a compiler that does
not support visibility. however, SHARED was the wrong condition to
test for this anyway; various assembly-language sources refer to
hidden symbols and declare them with the .hidden directive, making it
wrong to define the referenced symbols as non-hidden. if there is a
need in the future to build libc using compilers that lack visibility,
support could be moved to the build system or perhaps the __PIC__
macro could be checked instead of SHARED.
This commit is contained in:
Rich Felker
2015-11-11 19:29:45 -05:00
parent dc5bd27ac4
commit 8a8fdf6398
6 changed files with 5 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/internal/syscall.h
View File

@ -17,9 +17,7 @@
typedef long syscall_arg_t;
#endif
#ifdef SHARED
__attribute__((visibility("hidden")))
#endif
long __syscall_ret(unsigned long), __syscall(syscall_arg_t, ...),
__syscall_cp(syscall_arg_t, syscall_arg_t, syscall_arg_t, syscall_arg_t,
syscall_arg_t, syscall_arg_t, syscall_arg_t);