mirror of
https://github.com/fluencelabs/musl
synced 2025-07-31 06:11:57 +00:00
fix minor bugs due to incorrect threaded-predicate semantics
some functions that should have been testing whether pthread_self() had been called and initialized the thread pointer were instead testing whether pthread_create() had been called and actually made the program "threaded". while it's unlikely any mismatch would occur in real-world problems, this could have introduced subtle bugs. now, we store the address of the main thread's thread descriptor in the libc structure and use its presence as a flag that the thread register is initialized. note that after fork, the calling thread (not necessarily the original main thread) is the new main thread.
This commit is contained in:
@@ -6,7 +6,6 @@ static struct pthread main_thread;
|
||||
static const void *dummy[1] = { 0 };
|
||||
weak_alias(dummy, __pthread_tsd_main);
|
||||
|
||||
#undef errno
|
||||
static int *errno_location()
|
||||
{
|
||||
return __pthread_self()->errno_ptr;
|
||||
@@ -14,11 +13,10 @@ static int *errno_location()
|
||||
|
||||
static int init_main_thread()
|
||||
{
|
||||
if (__set_thread_area(&main_thread) < 0) return -1;
|
||||
main_thread.canceldisable = libc.canceldisable;
|
||||
main_thread.tsd = (void **)__pthread_tsd_main;
|
||||
main_thread.self = &main_thread;
|
||||
if (__set_thread_area(&main_thread) < 0)
|
||||
return -1;
|
||||
main_thread.self = libc.main_thread = &main_thread;
|
||||
main_thread.errno_ptr = __errno_location();
|
||||
libc.errno_location = errno_location;
|
||||
main_thread.tid = main_thread.pid =
|
||||
|
Reference in New Issue
Block a user