fluencelabs/musl
1
0
Fork 0
mirror of https://github.com/fluencelabs/musl synced 2025-06-26 21:22:11 +00:00
Code Issues Projects Releases Wiki Activity

system is a cancellation point

Browse Source 
ideally, system would also be cancellable while running the external
command, but I cannot find any way to make that work without either
leaking zombie processes or introducing behavior that is far outside
what the standard specifies. glibc handles cancellation by killing the
child process with SIGKILL, but this could be unsafe in that it could
leave the data being manipulated by the command in an inconsistent
state.
This commit is contained in:
Rich Felker
2012-10-28 21:17:45 -04:00
parent dd762cf6e5
commit 76f28cfce5
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/process/system.c
View File

@ -13,6 +13,7 @@ weak_alias(dummy_0, __acquire_ptc);
weak_alias(dummy_0, __release_ptc);
pid_t __vfork(void);
void __testcancel(void);
int system(const char *cmd)
{
@ -21,6 +22,8 @@ int system(const char *cmd)
struct sigaction sa = { .sa_handler = SIG_IGN }, oldint, oldquit;
int status = -1, i;
__testcancel();
if (!cmd) return 1;
sigaction(SIGINT, &sa, &oldint);