fluencelabs/musl
1
0
Fork 0
mirror of https://github.com/fluencelabs/musl synced 2025-04-24 23:02:14 +00:00
Code Issues Projects Releases Wiki Activity

fix return value of nice function

Browse Source 
the Linux SYS_nice syscall is unusable because it does not return the
newly set priority. always use SYS_setpriority. also avoid overflows
in addition of inc by handling large inc values directly without
examining the old nice value.
This commit is contained in:
Rich Felker 2018-04-16 17:35:43 -04:00
parent 424eab2225
commit 4bf0717e51
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/unistd/nice.c
View File

@ -1,12 +1,16 @@
#include <unistd.h> #include <unistd.h>
#include <sys/resource.h> #include <sys/resource.h>
#include <limits.h>
#include "syscall.h" #include "syscall.h"
int nice(int inc) int nice(int inc)
{ {
#ifdef SYS_nice int prio = inc;
return syscall(SYS_nice, inc); // Only query old priority if it can affect the result.
#else // This also avoids issues with integer overflow.
return setpriority(PRIO_PROCESS, 0, getpriority(PRIO_PROCESS, 0)+inc); if (inc > -2*NZERO && inc < 2*NZERO)
#endif prio += getpriority(PRIO_PROCESS, 0);
if (prio > NZERO-1) prio = NZERO-1;
if (prio < -NZERO) prio = -NZERO;
return setpriority(PRIO_PROCESS, 0, prio) ? -1 : prio;
} }