fluencelabs/jsonpath
1
0
Fork 0
mirror of https://github.com/fluencelabs/jsonpath synced 2025-04-25 17:32:15 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #2 from gkorland/cleanmutable

Browse Source 
remove unneeded mut
This commit is contained in:
changseok han 2019-05-14 10:52:58 +09:00 committed by GitHub
commit b49d95d5db
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/select/mod.rs
View File

@ -111,17 +111,17 @@ impl Selector {
self.value(&value) self.value(&value)
} }
fn jf(&mut self) -> result::Result<JsonValueFilter, String> { fn jf(&self) -> result::Result<JsonValueFilter, String> {
match &self.value { match &self.value {
Some(v) => Ok(JsonValueFilter::new_from_value(v.clone())), Some(v) => Ok(JsonValueFilter::new_from_value(v.clone())),
_ => return Err("Empty value".to_owned()) _ => return Err("Empty value".to_owned())
} }
} }
fn select(&mut self) -> result::Result<RefValueWrapper, String> { fn select(&self) -> result::Result<RefValueWrapper, String> {
let mut jf = self.jf()?; let mut jf = self.jf()?;
match &mut self.node { match &self.node {
Some(node) => { Some(node) => {
jf.visit(node.clone()); jf.visit(node.clone());
Ok(jf.take_value()) Ok(jf.take_value())
@ -130,17 +130,17 @@ impl Selector {
} }
} }
pub fn select_to_str(&mut self) -> result::Result<String, String> { pub fn select_to_str(&self) -> result::Result<String, String> {
serde_json::to_string(self.select()?.deref()).map_err(|e| format!("{:?}", e)) serde_json::to_string(self.select()?.deref()).map_err(|e| format!("{:?}", e))
} }
pub fn select_to_value(&mut self) -> result::Result<Value, String> { pub fn select_to_value(&self) -> result::Result<Value, String> {
Ok((&self.select()?).into()) Ok((&self.select()?).into())
} }
pub fn select_to<T: serde::de::DeserializeOwned>(&mut self) -> result::Result<T, String> { pub fn select_to<T: serde::de::DeserializeOwned>(&self) -> result::Result<T, String> {
let mut jf = self.jf()?; let mut jf = self.jf()?;
match &mut self.node { match &self.node {
Some(node) => { Some(node) => {
jf.visit(node.clone()); jf.visit(node.clone());
T::deserialize(jf.take_value().deref()).map_err(|e| format!("{:?}", e)) T::deserialize(jf.take_value().deref()).map_err(|e| format!("{:?}", e))