mirror of
https://github.com/fluencelabs/js-libp2p
synced 2025-06-19 04:01:24 +00:00
Fix a bug where `DialRequest` can abort wrong dial attempts. Co-authored-by: Robert Kiel <robert.kiel@hoprnet.io>
139 lines
4.4 KiB
TypeScript
139 lines
4.4 KiB
TypeScript
import errCode from 'err-code'
|
|
import { anySignal } from 'any-signal'
|
|
import FIFO from 'p-fifo'
|
|
// @ts-expect-error setMaxListeners is missing from the node 16 types
|
|
import { setMaxListeners } from 'events'
|
|
import { codes } from '../../errors.js'
|
|
import { logger } from '@libp2p/logger'
|
|
import type { Multiaddr } from '@multiformats/multiaddr'
|
|
import type { Connection } from '@libp2p/interfaces/connection'
|
|
import type { AbortOptions } from '@libp2p/interfaces'
|
|
import type { Dialer } from './index.js'
|
|
|
|
const log = logger('libp2p:dialer:dial-request')
|
|
|
|
export interface DialAction {
|
|
(m: Multiaddr, options: AbortOptions): Promise<Connection>
|
|
}
|
|
|
|
export interface DialRequestOptions {
|
|
addrs: Multiaddr[]
|
|
dialAction: DialAction
|
|
dialer: Dialer
|
|
}
|
|
|
|
export class DialRequest {
|
|
private readonly addrs: Multiaddr[]
|
|
private readonly dialer: Dialer
|
|
private readonly dialAction: DialAction
|
|
|
|
/**
|
|
* Manages running the `dialAction` on multiple provided `addrs` in parallel
|
|
* up to a maximum determined by the number of tokens returned
|
|
* from `dialer.getTokens`. Once a DialRequest is created, it can be
|
|
* started using `DialRequest.run(options)`. Once a single dial has succeeded,
|
|
* all other dials in the request will be cancelled.
|
|
*/
|
|
constructor (options: DialRequestOptions) {
|
|
const {
|
|
addrs,
|
|
dialAction,
|
|
dialer
|
|
} = options
|
|
|
|
this.addrs = addrs
|
|
this.dialer = dialer
|
|
this.dialAction = dialAction
|
|
}
|
|
|
|
async run (options: AbortOptions = {}): Promise<Connection> {
|
|
const tokens = this.dialer.getTokens(this.addrs.length)
|
|
|
|
// If no tokens are available, throw
|
|
if (tokens.length < 1) {
|
|
throw errCode(new Error('No dial tokens available'), codes.ERR_NO_DIAL_TOKENS)
|
|
}
|
|
|
|
const tokenHolder = new FIFO<number>()
|
|
|
|
for (const token of tokens) {
|
|
void tokenHolder.push(token).catch(err => {
|
|
log.error(err)
|
|
})
|
|
}
|
|
|
|
const dialAbortControllers: Array<(AbortController | undefined)> = this.addrs.map(() => {
|
|
const controller = new AbortController()
|
|
try {
|
|
// fails on node < 15.4
|
|
setMaxListeners?.(Infinity, controller.signal)
|
|
} catch {}
|
|
|
|
return controller
|
|
})
|
|
|
|
if (options.signal != null) {
|
|
try {
|
|
// fails on node < 15.4
|
|
setMaxListeners?.(Infinity, options.signal)
|
|
} catch {}
|
|
}
|
|
|
|
let completedDials = 0
|
|
let done = false
|
|
|
|
try {
|
|
return await Promise.any(this.addrs.map(async (addr, i) => {
|
|
const token = await tokenHolder.shift() // get token
|
|
// End attempt once another attempt succeeded
|
|
if (done) {
|
|
this.dialer.releaseToken(tokens.splice(tokens.indexOf(token), 1)[0])
|
|
throw errCode(new Error('dialAction already succeeded'), codes.ERR_ALREADY_SUCCEEDED)
|
|
}
|
|
|
|
const controller = dialAbortControllers[i]
|
|
if (controller == null) {
|
|
throw errCode(new Error('dialAction did not come with an AbortController'), codes.ERR_INVALID_PARAMETERS)
|
|
}
|
|
let conn
|
|
try {
|
|
const signal = controller.signal
|
|
conn = await this.dialAction(addr, { ...options, signal: (options.signal != null) ? anySignal([signal, options.signal]) : signal })
|
|
// Remove the successful AbortController so it is not aborted
|
|
dialAbortControllers[i] = undefined
|
|
} finally {
|
|
completedDials++
|
|
// If we have more or equal dials remaining than tokens, recycle the token, otherwise release it
|
|
if (this.addrs.length - completedDials >= tokens.length) {
|
|
void tokenHolder.push(token).catch(err => {
|
|
log.error(err)
|
|
})
|
|
} else {
|
|
this.dialer.releaseToken(tokens.splice(tokens.indexOf(token), 1)[0])
|
|
}
|
|
}
|
|
|
|
if (conn == null) {
|
|
// Notify Promise.any that attempt was not successful
|
|
// to prevent from returning undefined despite there
|
|
// were successful dial attempts
|
|
throw errCode(new Error('dialAction led to empty object'), codes.ERR_TRANSPORT_DIAL_FAILED)
|
|
} else {
|
|
// This dial succeeded, don't attempt anything else
|
|
done = true
|
|
}
|
|
|
|
return conn
|
|
}))
|
|
} finally {
|
|
// success/failure happened, abort everything else
|
|
dialAbortControllers.forEach(c => {
|
|
if (c !== undefined) {
|
|
c.abort()
|
|
}
|
|
})
|
|
tokens.forEach(token => this.dialer.releaseToken(token)) // release tokens back to the dialer
|
|
}
|
|
}
|
|
}
|