fix: wrap newStream errors to improve debuggability

CHANGELOG.md

@@ -1,3 +1,13 @@
+<a name="0.27.8"></a>
+## [0.27.8](https://github.com/libp2p/js-libp2p/compare/v0.27.7...v0.27.8) (2020-05-06)
+
+
+### Bug Fixes
+
+* reset discovery services upon stop ([#618](https://github.com/libp2p/js-libp2p/issues/618)) ([ea0621b](https://github.com/libp2p/js-libp2p/commit/ea0621b))
+
+
+
 <a name="0.27.7"></a>
 ## [0.27.7](https://github.com/libp2p/js-libp2p/compare/v0.27.6...v0.27.7) (2020-04-24)
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "libp2p",
-  "version": "0.27.7",
+  "version": "0.27.8",
   "description": "JavaScript implementation of libp2p, a modular peer to peer network stack",
   "leadMaintainer": "Jacob Heun <jacobheun@gmail.com>",
   "main": "src/index.js",
@@ -80,7 +80,7 @@
   "devDependencies": {
     "@nodeutils/defaults-deep": "^1.1.0",
     "abortable-iterator": "^3.0.0",
-    "aegir": "^21.9.0",
+    "aegir": "^21.10.1",
     "chai": "^4.2.0",
     "chai-as-promised": "^7.1.1",
     "cids": "^0.8.0",
@@ -128,26 +128,26 @@
     "Giovanni T. Parra <fiatjaf@gmail.com>",
     "Ryan Bell <ryan@piing.net>",
     "Thomas Eizinger <thomas@eizinger.io>",
+    "Didrik Nordström <didrik@betamos.se>",
+    "Joel Gustafson <joelg@mit.edu>",
     "Kevin Kwok <antimatter15@gmail.com>",
-    "Henrique Dias <hacdias@gmail.com>",
     "Nuno Nogueira <nunofmn@gmail.com>",
-    "RasmusErik Voel Jensen <github@solsort.com>",
     "Florian-Merle <florian.david.merle@gmail.com>",
+    "RasmusErik Voel Jensen <github@solsort.com>",
+    "Fei Liu <liu.feiwood@gmail.com>",
     "Soeren <nikorpoulsen@gmail.com>",
     "Sönke Hahn <soenkehahn@gmail.com>",
     "Tiago Alves <alvesjtiago@gmail.com>",
-    "Fei Liu <liu.feiwood@gmail.com>",
     "Dmitriy Ryajov <dryajov@gmail.com>",
     "Diogo Silva <fsdiogo@gmail.com>",
     "Yusef Napora <yusef@napora.org>",
     "Zane Starr <zcstarr@gmail.com>",
-    "Didrik Nordström <didrik.nordstrom@gmail.com>",
     "Daijiro Wachi <daijiro.wachi@gmail.com>",
     "ebinks <elizabethjbinks@gmail.com>",
     "Chris Bratlien <chrisbratlien@gmail.com>",
     "isan_rivkin <isanrivkin@gmail.com>",
     "robertkiel <robert.kiel@validitylabs.org>",
     "Irakli Gozalishvili <rfobic@gmail.com>",
-    "Joel Gustafson <joelg@mit.edu>"
+    "Henrique Dias <hacdias@gmail.com>"
   ]
 }

src/upgrader.js

@@ -253,7 +253,7 @@ class Upgrader {
           return { stream: { ...muxedStream, ...stream }, protocol }
         } catch (err) {
           log.error('could not create new stream', err)
-          throw errCode(err, codes.ERR_UNSUPPORTED_PROTOCOL)
+          throw errCode(new Error('Could not create a new stream'), codes.ERR_UNSUPPORTED_PROTOCOL, { cause: err })
         }
       }
 

test/upgrading/upgrader.spec.js

@@ -339,6 +339,7 @@ describe('Upgrader', () => {
     results.forEach(result => {
       expect(result.isRejected).to.equal(true)
       expect(result.reason.code).to.equal(codes.ERR_UNSUPPORTED_PROTOCOL)
+      expect(result.reason.cause).to.exist()
     })
   })
 })