fluencelabs/js-libp2p
1
0
Fork 0
mirror of https://github.com/fluencelabs/js-libp2p synced 2025-04-25 18:42:15 +00:00
Code Issues Projects Releases Wiki Activity

fix: address book guarantees no replicated entries are added (#927)

Browse Source
This commit is contained in:
Vasco Santos 2021-04-27 17:14:48 +02:00 committed by GitHub
parent ef4393649f
commit ac370fc967
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/peer-store/address-book.js
View File

@ -307,10 +307,13 @@ class AddressBook extends Book {
throw errcode(new Error(`multiaddr ${addr} must be an instance of multiaddr`), ERR_INVALID_PARAMETERS) throw errcode(new Error(`multiaddr ${addr} must be an instance of multiaddr`), ERR_INVALID_PARAMETERS)
} }
// Guarantee no replicates
if (!addresses.find((a) => a.multiaddr.equals(addr))) {
addresses.push({ addresses.push({
multiaddr: addr, multiaddr: addr,
isCertified isCertified
}) })
}
}) })
return addresses return addresses

8
test/peer-store/address-book.spec.js
View File

@ -287,6 +287,14 @@ describe('addressBook', () => {
await defer.promise await defer.promise
}) })
it('does not add replicated content', () => {
// set 1
ab.set(peerId, [addr1, addr1])
const addresses = ab.get(peerId)
expect(addresses).to.have.lengthOf(1)
})
}) })
describe('addressBook.get', () => { describe('addressBook.get', () => {