mirror of
https://github.com/fluencelabs/js-libp2p
synced 2025-06-23 22:11:35 +00:00
feat: async peerstore backed by datastores (#1058)
We have a peerstore that keeps all data for all observed peers in memory with no eviction. This is fine when you don't discover many peers but when using the DHT you encounter a significant number of peers so our peer storage grows and grows over time. We have a persistent peer store, but it just periodically writes peers into the datastore to be read at startup, still keeping them in memory. It also means a restart doesn't give you any temporary reprieve from the memory leak as the previously observed peer data is read into memory at startup. This change refactors the peerstore to use a datastore by default, reading and writing peer info as it arrives. It can be configured with a MemoryDatastore if desired. It was necessary to change the peerstore and *book interfaces to be asynchronous since the datastore api is asynchronous. BREAKING CHANGE: `libp2p.handle`, `libp2p.registrar.register` and the peerstore methods have become async
This commit is contained in:
@ -13,7 +13,7 @@ const Topology = require('libp2p-interfaces/src/topology')
|
||||
|
||||
/**
|
||||
* @typedef {import('peer-id')} PeerId
|
||||
* @typedef {import('./peer-store')} PeerStore
|
||||
* @typedef {import('./peer-store/types').PeerStore} PeerStore
|
||||
* @typedef {import('./connection-manager')} ConnectionManager
|
||||
* @typedef {import('libp2p-interfaces/src/connection').Connection} Connection
|
||||
* @typedef {import('./').HandlerProps} HandlerProps
|
||||
@ -82,9 +82,9 @@ class Registrar {
|
||||
* Register handlers for a set of multicodecs given
|
||||
*
|
||||
* @param {Topology} topology - protocol topology
|
||||
* @returns {string} registrar identifier
|
||||
* @returns {Promise<string>} registrar identifier
|
||||
*/
|
||||
register (topology) {
|
||||
async register (topology) {
|
||||
if (!Topology.isTopology(topology)) {
|
||||
log.error('topology must be an instance of interfaces/topology')
|
||||
throw errcode(new Error('topology must be an instance of interfaces/topology'), ERR_INVALID_PARAMETERS)
|
||||
@ -96,7 +96,7 @@ class Registrar {
|
||||
this.topologies.set(id, topology)
|
||||
|
||||
// Set registrar
|
||||
topology.registrar = this
|
||||
await topology.setRegistrar(this)
|
||||
|
||||
return id
|
||||
}
|
||||
|
Reference in New Issue
Block a user