From 4e01c094bc9579122a77f210c7e379e835eb9b9f Mon Sep 17 00:00:00 2001
From: David Dias <daviddias.p@gmail.com>
Date: Thu, 15 Feb 2018 20:14:54 +0100
Subject: [PATCH] test: test pubsub on and off

---
 src/pubsub.js       |  8 ++--
 test/pubsub.node.js | 93 +++++++++++++++++++++++++++++++--------------
 2 files changed, 68 insertions(+), 33 deletions(-)

diff --git a/src/pubsub.js b/src/pubsub.js
index 525cb9a5..9bff4a1c 100644
--- a/src/pubsub.js
+++ b/src/pubsub.js
@@ -11,16 +11,16 @@ module.exports = (node) => {
 
   return {
     subscribe: (topic, options, handler, callback) => {
-      if (!node.isStarted() && !floodSub.started) {
-        return setImmediate(() => callback(new Error(NOT_STARTED_YET)))
-      }
-
       if (typeof options === 'function') {
         callback = handler
         handler = options
         options = {}
       }
 
+      if (!node.isStarted() && !floodSub.started) {
+        return setImmediate(() => callback(new Error(NOT_STARTED_YET)))
+      }
+
       function subscribe (cb) {
         if (floodSub.listenerCount(topic) === 0) {
           floodSub.subscribe(topic)
diff --git a/test/pubsub.node.js b/test/pubsub.node.js
index 8dbde560..310c6753 100644
--- a/test/pubsub.node.js
+++ b/test/pubsub.node.js
@@ -7,46 +7,81 @@ const chai = require('chai')
 chai.use(require('dirty-chai'))
 const expect = chai.expect
 const parallel = require('async/parallel')
+const waterfall = require('async/waterfall')
 const _times = require('lodash.times')
 const utils = require('./utils/node')
 const createNode = utils.createNode
 
-describe('.pubsub', () => {
-  let nodeA
-  let nodeB
-
-  before(function (done) {
-    this.timeout(5 * 1000)
-
-    const tasks = _times(2, () => (cb) => {
-      createNode('/ip4/0.0.0.0/tcp/0', {
-        mdns: false,
-        dht: true
-      }, (err, node) => {
-        expect(err).to.not.exist()
-        node.start((err) => cb(err, node))
-      })
-    })
-
-    parallel(tasks, (err, nodes) => {
+function startTwo (callback) {
+  const tasks = _times(2, () => (cb) => {
+    createNode('/ip4/0.0.0.0/tcp/0', {
+      mdns: false
+    }, (err, node) => {
       expect(err).to.not.exist()
-      nodeA = nodes[0]
-      nodeB = nodes[1]
-
-      nodeA.dial(nodeB.peerInfo, done)
+      node.start((err) => cb(err, node))
     })
   })
 
-  after((done) => {
-    parallel([
-      (cb) => nodeA.stop(cb),
-      (cb) => nodeB.stop(cb)
-    ], done)
-  })
+  parallel(tasks, (err, nodes) => {
+    expect(err).to.not.exist()
 
-  describe('.pubsub on (default)', () => {
+    nodes[0].dial(nodes[1].peerInfo, (err) => callback(err, nodes))
+  })
+}
+
+function stopTwo (nodes, callback) {
+  parallel([
+    (cb) => nodes[0].stop(cb),
+    (cb) => nodes[1].stop(cb)
+  ], callback)
+}
+
+// There is a vast test suite on PubSub through js-ipfs
+// https://github.com/ipfs/interface-ipfs-core/blob/master/js/src/pubsub.js
+// and libp2p-floodsub itself
+// https://github.com/libp2p/js-libp2p-floodsub/tree/master/test
+// TODO: consider if all or some of those should come here
+describe('.pubsub', () => {
+  describe('.pubsub on (default)', (done) => {
+    it('start two nodes and send one message', (done) => {
+      waterfall([
+        (cb) => startTwo(cb),
+        (nodes, cb) => {
+          const data = Buffer.from('test')
+          nodes[0].pubsub.subscribe('pubsub',
+            (msg) => {
+              expect(msg.data).to.eql(data)
+              cb(null, nodes)
+            },
+            (err) => {
+              expect(err).to.not.exist()
+              setTimeout(() => nodes[1].pubsub.publish('pubsub', data, (err) => {
+                expect(err).to.not.exist()
+              }), 500)
+            }
+          )
+        },
+        (nodes, cb) => stopTwo(nodes, cb)
+      ], done)
+    })
   })
 
   describe('.pubsub off', () => {
+    it('fail to use pubsub if disabled', (done) => {
+      createNode('/ip4/0.0.0.0/tcp/0', {
+        mdns: false,
+        pubsub: false
+      }, (err, node) => {
+        expect(err).to.not.exist()
+
+        node.pubsub.subscribe('news',
+          (msg) => {},
+          (err) => {
+            expect(err).to.exist()
+            done()
+          }
+        )
+      })
+    })
   })
 })