fix: signature compliant with spec

test/record/envelope.spec.js

@@ -6,18 +6,18 @@ chai.use(require('dirty-chai'))
 chai.use(require('chai-bytes'))
 const { expect } = chai
 
-const multicodec = require('multicodec')
-
 const Envelope = require('../../src/record/envelope')
 const Record = require('libp2p-interfaces/src/record')
+const { codes: ErrorCodes } = require('../../src/errors')
 
 const peerUtils = require('../utils/creators/peer')
 
-const domain = '/test-domain'
+const domain = 'libp2p-testing'
+const codec = '/libp2p/testdata'
 
 class TestRecord extends Record {
   constructor (data) {
-    super(domain, multicodec.LIBP2P_PEER_RECORD)
+    super(domain, codec)
     this.data = data
   }
 
@@ -31,7 +31,7 @@ class TestRecord extends Record {
 }
 
 describe('Envelope', () => {
-  const payloadType = Buffer.from(`${multicodec.print[multicodec.LIBP2P_PEER_RECORD]}${domain}`)
+  const payloadType = Buffer.from(codec)
   let peerId
   let testRecord
 
@@ -78,11 +78,12 @@ describe('Envelope', () => {
     expect(isEqual).to.eql(true)
   })
 
-  it.skip('throw on open and verify when a different domain is used', async () => {
+  it('throw on open and verify when a different domain is used', async () => {
     const envelope = await Envelope.seal(testRecord, peerId)
     const rawEnvelope = envelope.marshal()
 
-    await expect(Envelope.openAndCertify(rawEnvelope, '/fake-domain'))
-      .to.eventually.rejected()
+    await expect(Envelope.openAndCertify(rawEnvelope, '/bad-domain'))
+      .to.eventually.be.rejected()
+      .and.to.have.property('code', ErrorCodes.ERR_SIGNATURE_NOT_VALID)
   })
 })

test/record/peer-record.spec.js

@@ -5,9 +5,10 @@ const chai = require('chai')
 chai.use(require('dirty-chai'))
 const { expect } = chai
 
+const tests = require('libp2p-interfaces/src/record/tests')
 const multiaddr = require('multiaddr')
 
-const tests = require('libp2p-interfaces/src/record/tests')
+const Envelope = require('../../src/record/envelope')
 const PeerRecord = require('../../src/record/peer-record')
 
 const peerUtils = require('../utils/creators/peer')
@@ -113,5 +114,28 @@ describe('PeerRecord', () => {
 })
 
 describe('PeerRecord inside Envelope', () => {
-  // TODO
+  let peerId
+  let peerRecord
+
+  before(async () => {
+    [peerId] = await peerUtils.createPeerId()
+    const multiaddrs = [
+      multiaddr('/ip4/127.0.0.1/tcp/2000')
+    ]
+    const seqNumber = Date.now()
+    peerRecord = new PeerRecord({ peerId, multiaddrs, seqNumber })
+  })
+
+  it('creates an envelope with the PeerRecord and can unmarshal it', async () => {
+    const e = await Envelope.seal(peerRecord, peerId)
+    const byteE = e.marshal()
+
+    const decodedE = await Envelope.openAndCertify(byteE, peerRecord.domain)
+    expect(decodedE).to.exist()
+
+    const decodedPeerRecord = PeerRecord.createFromProtobuf(decodedE.payload)
+
+    const isEqual = peerRecord.isEqual(decodedPeerRecord)
+    expect(isEqual).to.eql(true)
+  })
 })