fluencelabs/js-libp2p
1
0
Fork 0
mirror of https://github.com/fluencelabs/js-libp2p synced 2025-04-25 10:32:14 +00:00
Code Issues Projects Releases Wiki Activity

fix: do not auto-dial after shut down

Browse Source 
The `await` in the auto-connect loop means we can start a dial after
shutdown but before we test to see if we should break out of the
loop.

Instead, use the `this._started` property to break out of the loop,
then test again to see if we should use retimer to schedule a further
auto-dial attempt.

Fixes: https://github.com/ipfs/js-ipfs/issues/3923
This commit is contained in:
achingbrain 2021-11-26 17:06:22 +00:00
parent eacd7e8f76
commit 474d865d9f
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/connection-manager/index.js
View File

@ -340,22 +340,22 @@ class ConnectionManager extends EventEmitter {
return -1 return -1
}) })
for (let i = 0; i < peers.length && this.size < minConnections; i++) { for (let i = 0; i < peers.length && this.size < minConnections && this._started; i++) {
if (!this.get(peers[i].id)) { if (!this.get(peers[i].id)) {
log('connecting to a peerStore stored peer %s', peers[i].id.toB58String()) log('connecting to a peerStore stored peer %s', peers[i].id.toB58String())
try { try {
await this._libp2p.dialer.connectToPeer(peers[i].id) await this._libp2p.dialer.connectToPeer(peers[i].id)
// Connection Manager was stopped
if (!this._started) {
return
}
} catch (/** @type {any} */ err) { } catch (/** @type {any} */ err) {
log.error('could not connect to peerStore stored peer', err) log.error('could not connect to peerStore stored peer', err)
} }
} }
} }
// Connection Manager was stopped
if (!this._started) {
return
}
this._autoDialTimeout = retimer(this._autoDial, this._options.autoDialInterval) this._autoDialTimeout = retimer(this._autoDial, this._options.autoDialInterval)
} }