fix: replace node buffers with uint8arrays (#115)

* fix: replace node buffers with uint8arrays

BREAKING CHANGES:

- All deps used by this module now use Uint8Arrays in place of Buffers

* chore: remove gh dep
This commit is contained in:
Alex Potsides
2020-08-11 14:54:49 +01:00
committed by GitHub
parent a37c2bd7f7
commit a277bf6bfb
4 changed files with 22 additions and 29 deletions

View File

@ -1,15 +1,13 @@
/* eslint-env mocha */
'use strict'
const chai = require('chai')
const dirtyChai = require('dirty-chai')
const expect = chai.expect
chai.use(dirtyChai)
const { expect } = require('aegir/utils/chai')
const multiaddr = require('multiaddr')
const pipe = require('it-pipe')
const goodbye = require('it-goodbye')
const { collect, take } = require('streaming-iterables')
const uint8ArrayFromString = require('uint8arrays/from-string')
const WS = require('../src')
@ -29,7 +27,7 @@ describe('libp2p-websockets', () => {
})
it('echo', async () => {
const message = Buffer.from('Hello World!')
const message = uint8ArrayFromString('Hello World!')
const s = goodbye({ source: [message], sink: collect })
const results = await pipe(s, conn, s)
@ -38,7 +36,7 @@ describe('libp2p-websockets', () => {
describe('stress', () => {
it('one big write', async () => {
const rawMessage = Buffer.allocUnsafe(1000000).fill('a')
const rawMessage = new Uint8Array(1000000).fill('a')
const s = goodbye({ source: [rawMessage], sink: collect })
@ -52,7 +50,7 @@ describe('libp2p-websockets', () => {
source: pipe(
{
[Symbol.iterator] () { return this },
next: () => ({ done: false, value: Buffer.from(Math.random().toString()) })
next: () => ({ done: false, value: uint8ArrayFromString(Math.random().toString()) })
},
take(20000)
),

View File

@ -5,15 +5,13 @@
const https = require('https')
const fs = require('fs')
const chai = require('chai')
const dirtyChai = require('dirty-chai')
const expect = chai.expect
chai.use(dirtyChai)
const { expect } = require('aegir/utils/chai')
const multiaddr = require('multiaddr')
const goodbye = require('it-goodbye')
const { collect } = require('streaming-iterables')
const pipe = require('it-pipe')
const BufferList = require('bl/BufferList')
const uint8ArrayFromString = require('uint8arrays/from-string')
const WS = require('../src')
@ -211,7 +209,7 @@ describe('dial', () => {
const result = await pipe(s, conn, s)
expect(result).to.be.eql([Buffer.from('hey')])
expect(result).to.be.eql([uint8ArrayFromString('hey')])
})
it('dial with p2p Id', async () => {
@ -221,7 +219,7 @@ describe('dial', () => {
const result = await pipe(s, conn, s)
expect(result).to.be.eql([Buffer.from('hey')])
expect(result).to.be.eql([uint8ArrayFromString('hey')])
})
it('should resolve port 0', async () => {
@ -276,7 +274,7 @@ describe('dial', () => {
const result = await pipe(s, conn, s)
expect(result).to.be.eql([Buffer.from('hey')])
expect(result).to.be.eql([uint8ArrayFromString('hey')])
})
})
@ -299,7 +297,7 @@ describe('dial', () => {
const result = await pipe(s, conn, s)
expect(result).to.be.eql([Buffer.from('hey')])
expect(result).to.be.eql([uint8ArrayFromString('hey')])
})
it('dial and use BufferList', async () => {
@ -308,7 +306,7 @@ describe('dial', () => {
const result = await pipe(s, conn, s)
expect(result).to.be.eql([Buffer.from('hey')])
expect(result).to.be.eql([uint8ArrayFromString('hey')])
})
it('dial with p2p Id', async () => {
@ -321,7 +319,7 @@ describe('dial', () => {
})
const result = await pipe(s, conn, s)
expect(result).to.be.eql([Buffer.from('hey')])
expect(result).to.be.eql([uint8ArrayFromString('hey')])
})
})
})