chore: release version v0.11.3

* test: do not run IPv6 tests on CI

* Updating CI files (#83)

This commit updates all CI scripts to the latest version

* chore: use env variable instead

* skip the other IPv6 tests

.gitignore

@@ -1,3 +1,4 @@
+docs
 **/node_modules/
 **/*.log
 test/repo-tests*

.travis.yml

@@ -1,3 +1,4 @@
+# Warning: This file is automatically synced from https://github.com/ipfs/ci-sync so if you want to change it, please change it there and ask someone to sync all repositories.
 sudo: false
 language: node_js
 
@@ -14,7 +15,6 @@ script:
   - npm run lint
   - npm run test
   - npm run coverage
-  - make test
 
 before_script:
   - export DISPLAY=:99.0

CHANGELOG.md

@@ -0,0 +1,218 @@
+<a name="0.11.3"></a>
+## [0.11.3](https://github.com/libp2p/js-libp2p-tcp/compare/v0.11.2...v0.11.3) (2018-02-07)
+
+
+### Bug Fixes
+
+* clearing timeout when closes ([#87](https://github.com/libp2p/js-libp2p-tcp/issues/87)) ([f8f5266](https://github.com/libp2p/js-libp2p-tcp/commit/f8f5266))
+
+
+
+<a name="0.11.2"></a>
+## [0.11.2](https://github.com/libp2p/js-libp2p-tcp/compare/v0.11.1...v0.11.2) (2018-01-12)
+
+
+### Bug Fixes
+
+* missing dependency debug, fixes [#84](https://github.com/libp2p/js-libp2p-tcp/issues/84) ([74a88f6](https://github.com/libp2p/js-libp2p-tcp/commit/74a88f6))
+
+
+
+<a name="0.11.1"></a>
+## [0.11.1](https://github.com/libp2p/js-libp2p-tcp/compare/v0.11.0...v0.11.1) (2017-10-13)
+
+
+### Features
+
+* relay filtering  ([11c4f45](https://github.com/libp2p/js-libp2p-tcp/commit/11c4f45))
+
+
+
+<a name="0.11.0"></a>
+# [0.11.0](https://github.com/libp2p/js-libp2p-tcp/compare/v0.10.2...v0.11.0) (2017-09-03)
+
+
+### Features
+
+* p2p addrs situation ([#82](https://github.com/libp2p/js-libp2p-tcp/issues/82)) ([a54bb83](https://github.com/libp2p/js-libp2p-tcp/commit/a54bb83))
+
+
+
+<a name="0.10.2"></a>
+## [0.10.2](https://github.com/libp2p/js-libp2p-tcp/compare/v0.10.1...v0.10.2) (2017-07-22)
+
+
+
+<a name="0.10.1"></a>
+## [0.10.1](https://github.com/libp2p/js-libp2p-tcp/compare/v0.10.0...v0.10.1) (2017-04-13)
+
+
+### Bug Fixes
+
+* catch errors on incomming sockets ([e204517](https://github.com/libp2p/js-libp2p-tcp/commit/e204517))
+
+
+
+<a name="0.10.0"></a>
+# [0.10.0](https://github.com/libp2p/js-libp2p-tcp/compare/v0.9.4...v0.10.0) (2017-03-27)
+
+
+### Bug Fixes
+
+* **dial:** proper error handling on dial ([#77](https://github.com/libp2p/js-libp2p-tcp/issues/77)) ([4d4f295](https://github.com/libp2p/js-libp2p-tcp/commit/4d4f295))
+
+
+
+<a name="0.9.4"></a>
+## [0.9.4](https://github.com/libp2p/js-libp2p-tcp/compare/v0.9.3...v0.9.4) (2017-03-21)
+
+
+
+<a name="0.9.3"></a>
+## [0.9.3](https://github.com/libp2p/js-libp2p-tcp/compare/v0.9.2...v0.9.3) (2017-02-09)
+
+
+
+<a name="0.9.2"></a>
+## [0.9.2](https://github.com/libp2p/js-libp2p-tcp/compare/v0.9.1...v0.9.2) (2017-02-09)
+
+
+
+<a name="0.9.1"></a>
+## [0.9.1](https://github.com/libp2p/js-libp2p-tcp/compare/v0.9.0...v0.9.1) (2016-11-03)
+
+
+
+<a name="0.9.0"></a>
+# [0.9.0](https://github.com/libp2p/js-libp2p-tcp/compare/v0.8.1...v0.9.0) (2016-11-03)
+
+
+### Bug Fixes
+
+* **deps:** remove unused pull dep ([06689e3](https://github.com/libp2p/js-libp2p-tcp/commit/06689e3))
+
+
+
+<a name="0.8.1"></a>
+## [0.8.1](https://github.com/libp2p/js-libp2p-tcp/compare/v0.8.0...v0.8.1) (2016-09-06)
+
+
+
+<a name="0.8.0"></a>
+# [0.8.0](https://github.com/libp2p/js-libp2p-tcp/compare/v0.7.4...v0.8.0) (2016-09-06)
+
+
+### Features
+
+* **deps:** update to published deps ([da8ee21](https://github.com/libp2p/js-libp2p-tcp/commit/da8ee21))
+* **pull:** migration to pull-streams ([5e89a26](https://github.com/libp2p/js-libp2p-tcp/commit/5e89a26))
+* **readme:** add pull-streams documentation ([d9f65e0](https://github.com/libp2p/js-libp2p-tcp/commit/d9f65e0))
+
+
+
+<a name="0.7.4"></a>
+## [0.7.4](https://github.com/libp2p/js-libp2p-tcp/compare/v0.7.3...v0.7.4) (2016-08-03)
+
+
+
+<a name="0.7.3"></a>
+## [0.7.3](https://github.com/libp2p/js-libp2p-tcp/compare/v0.7.2...v0.7.3) (2016-06-26)
+
+
+
+<a name="0.7.2"></a>
+## [0.7.2](https://github.com/libp2p/js-libp2p-tcp/compare/v0.7.1...v0.7.2) (2016-06-23)
+
+
+
+<a name="0.7.1"></a>
+## [0.7.1](https://github.com/libp2p/js-libp2p-tcp/compare/v0.7.0...v0.7.1) (2016-06-23)
+
+
+### Bug Fixes
+
+* error was passed in duplicate ([9ac5cca](https://github.com/libp2p/js-libp2p-tcp/commit/9ac5cca))
+
+
+
+<a name="0.7.0"></a>
+# [0.7.0](https://github.com/libp2p/js-libp2p-tcp/compare/v0.6.2...v0.7.0) (2016-06-22)
+
+
+
+<a name="0.6.2"></a>
+## [0.6.2](https://github.com/libp2p/js-libp2p-tcp/compare/v0.6.1...v0.6.2) (2016-06-01)
+
+
+### Bug Fixes
+
+* address cr ([2ed01e8](https://github.com/libp2p/js-libp2p-tcp/commit/2ed01e8))
+* destroy hanging connections after timeout ([4a12169](https://github.com/libp2p/js-libp2p-tcp/commit/4a12169))
+
+
+
+<a name="0.6.1"></a>
+## [0.6.1](https://github.com/libp2p/js-libp2p-tcp/compare/v0.6.0...v0.6.1) (2016-05-29)
+
+
+
+<a name="0.6.0"></a>
+# [0.6.0](https://github.com/libp2p/js-libp2p-tcp/compare/v0.5.3...v0.6.0) (2016-05-22)
+
+
+
+<a name="0.5.3"></a>
+## [0.5.3](https://github.com/libp2p/js-libp2p-tcp/compare/v0.5.2...v0.5.3) (2016-05-22)
+
+
+
+<a name="0.5.2"></a>
+## [0.5.2](https://github.com/libp2p/js-libp2p-tcp/compare/v0.5.1...v0.5.2) (2016-05-09)
+
+
+
+<a name="0.5.1"></a>
+## [0.5.1](https://github.com/libp2p/js-libp2p-tcp/compare/v0.5.0...v0.5.1) (2016-05-08)
+
+
+
+<a name="0.5.0"></a>
+# [0.5.0](https://github.com/libp2p/js-libp2p-tcp/compare/v0.4.0...v0.5.0) (2016-04-25)
+
+
+
+<a name="0.4.0"></a>
+# [0.4.0](https://github.com/libp2p/js-libp2p-tcp/compare/v0.3.0...v0.4.0) (2016-03-14)
+
+
+
+<a name="0.3.0"></a>
+# [0.3.0](https://github.com/libp2p/js-libp2p-tcp/compare/v0.2.1...v0.3.0) (2016-03-10)
+
+
+
+<a name="0.2.1"></a>
+## [0.2.1](https://github.com/libp2p/js-libp2p-tcp/compare/v0.2.0...v0.2.1) (2016-03-04)
+
+
+
+<a name="0.2.0"></a>
+# [0.2.0](https://github.com/libp2p/js-libp2p-tcp/compare/v0.1.2...v0.2.0) (2016-03-04)
+
+
+
+<a name="0.1.2"></a>
+## [0.1.2](https://github.com/libp2p/js-libp2p-tcp/compare/v0.1.1...v0.1.2) (2015-10-29)
+
+
+
+<a name="0.1.1"></a>
+## [0.1.1](https://github.com/libp2p/js-libp2p-tcp/compare/v0.1.0...v0.1.1) (2015-09-17)
+
+
+
+<a name="0.1.0"></a>
+# 0.1.0 (2015-09-16)
+
+
+

appveyor.yml

@@ -0,0 +1,29 @@
+# Warning: This file is automatically synced from https://github.com/ipfs/ci-sync so if you want to change it, please change it there and ask someone to sync all repositories.
+version: "{build}"
+
+environment:
+  matrix:
+    - nodejs_version: "6"
+    - nodejs_version: "8"
+
+matrix:
+  fast_finish: true
+
+install:
+  # Install Node.js
+  - ps: Install-Product node $env:nodejs_version
+
+  # Upgrade npm
+  - npm install -g npm
+
+  # Output our current versions for debugging
+  - node --version
+  - npm --version
+
+  # Install our package dependencies
+  - npm install
+
+test_script:
+  - npm run test:node
+
+build: off

ci/Jenkinsfile

@@ -0,0 +1,2 @@
+// Warning: This file is automatically synced from https://github.com/ipfs/ci-sync so if you want to change it, please change it there and ask someone to sync all repositories.
+javascript()

circle.yml

@@ -1,3 +1,4 @@
+# Warning: This file is automatically synced from https://github.com/ipfs/ci-sync so if you want to change it, please change it there and ask someone to sync all repositories.
 machine:
   node:
     version: stable

package.json

@@ -1,18 +1,18 @@
 {
   "name": "libp2p-tcp",
-  "version": "0.11.0",
+  "version": "0.11.3",
   "description": "Node.js implementation of the TCP module that libp2p uses, which implements the interface-connection and interface-transport interfaces",
   "main": "src/index.js",
   "scripts": {
-    "lint": "aegir-lint",
-    "test": "aegir-test --env node",
-    "release": "aegir-release --env no-build",
-    "release-minor": "aegir-release --type minor --env no-build",
-    "release-major": "aegir-release --type major --env no-build",
-    "coverage": "aegir-coverage",
-    "coverage-publish": "aegir-coverage publish"
+    "lint": "aegir lint",
+    "test": "aegir test -t node",
+    "release": "aegir release -t node --no-build",
+    "release-minor": "aegir release -t node --type minor --no-build",
+    "release-major": "aegir-release -t node --type major --no-build",
+    "coverage": "aegir coverage",
+    "coverage-publish": "aegir coverage --provider coveralls"
   },
-  "pre-commit": [
+  "pre-push": [
     "lint",
     "test"
   ],
@@ -34,30 +34,34 @@
     "npm": ">=3.0.0"
   },
   "devDependencies": {
-    "aegir": "^11.0.2",
+    "aegir": "^12.4.0",
     "chai": "^4.1.2",
     "dirty-chai": "^2.0.1",
     "interface-transport": "~0.3.5",
-    "lodash.isfunction": "^3.0.8",
+    "lodash.isfunction": "^3.0.9",
     "pre-commit": "^1.2.2",
-    "pull-stream": "^3.6.0"
+    "pull-stream": "^3.6.1"
   },
   "dependencies": {
+    "debug": "^3.1.0",
     "interface-connection": "~0.3.2",
-    "ip-address": "^5.8.8",
+    "ip-address": "^5.8.9",
     "lodash.includes": "^4.3.0",
-    "lodash.isfunction": "^3.0.8",
-    "mafmt": "^3.0.0",
-    "multiaddr": "^3.0.0",
+    "lodash.isfunction": "^3.0.9",
+    "mafmt": "^3.0.2",
+    "multiaddr": "^3.0.2",
     "once": "^1.4.0",
     "stream-to-pull-stream": "^1.7.2"
   },
   "contributors": [
+    "Alan Shaw <alan@tableflip.io>",
     "David Dias <daviddias.p@gmail.com>",
+    "Dmitriy Ryajov <dryajov@gmail.com>",
     "Evan Schwartz <evan.mark.schwartz@gmail.com>",
     "Friedel Ziegelmayer <dignifiedquire@gmail.com>",
     "Greenkeeper <support@greenkeeper.io>",
     "João Antunes <j.goncalo.antunes@gmail.com>",
+    "Pedro Teixeira <i@pgte.me>",
     "Prashanth Chandra <coolshanth94@gmail.com>",
     "Richard Littauer <richard.littauer@gmail.com>",
     "Stephen Whitmore <stephen.whitmore@gmail.com>"

src/index.js

@@ -67,10 +67,16 @@ class TCP {
     if (!Array.isArray(multiaddrs)) {
       multiaddrs = [multiaddrs]
     }
+
     return multiaddrs.filter((ma) => {
+      if (includes(ma.protoNames(), 'p2p-circuit')) {
+        return false
+      }
+
       if (includes(ma.protoNames(), 'ipfs')) {
         ma = ma.decapsulate('ipfs')
       }
+
       return mafmt.TCP.matches(ma)
     })
   }

src/listener.js

@@ -55,23 +55,19 @@ module.exports = (handler) => {
     callback = callback || noop
     options = options || {}
 
-    let closed = false
-    server.close(callback)
-
-    server.once('close', () => {
-      closed = true
-    })
-    setTimeout(() => {
-      if (closed) {
-        return
-      }
-
+    const timeout = setTimeout(() => {
       log('unable to close graciously, destroying conns')
       Object.keys(server.__connections).forEach((key) => {
         log('destroying %s', key)
         server.__connections[key].destroy()
       })
     }, options.timeout || CLOSE_TIMEOUT)
+
+    server.close(callback)
+
+    server.once('close', () => {
+      clearTimeout(timeout)
+    })
   }
 
   let ipfsId

test/index.spec.js

@@ -10,6 +10,7 @@ const TCP = require('../src')
 const net = require('net')
 const multiaddr = require('multiaddr')
 const Connection = require('interface-connection').Connection
+const isCI = process.env.CI
 
 describe('instantiate the transport', () => {
   it('create', () => {
@@ -54,6 +55,7 @@ describe('listen', () => {
   })
 
   it('listen on IPv6 addr', (done) => {
+    if (isCI) { return done() }
     const mh = multiaddr('/ip6/::/tcp/9090')
     const listener = tcp.createListener((conn) => {})
     listener.listen(mh, () => {
@@ -144,7 +146,7 @@ describe('dial', () => {
     listener = tcp.createListener((conn) => {
       pull(
         conn,
-        pull.map((x) => new Buffer(x.toString() + '!')),
+        pull.map((x) => Buffer.from(x.toString() + '!')),
         conn
       )
     })
@@ -161,7 +163,7 @@ describe('dial', () => {
       tcp.dial(ma),
       pull.collect((err, values) => {
         expect(err).to.not.exist()
-        expect(values).to.eql([new Buffer('hey!')])
+        expect(values).to.eql([Buffer.from('hey!')])
         done()
       })
     )
@@ -179,6 +181,8 @@ describe('dial', () => {
   })
 
   it('dial on IPv6', (done) => {
+    if (isCI) { return done() }
+
     const ma = multiaddr('/ip6/::/tcp/9066')
     const listener = tcp.createListener((conn) => {
       pull(conn, conn)
@@ -190,7 +194,7 @@ describe('dial', () => {
         pull.collect((err, values) => {
           expect(err).to.not.exist()
 
-          expect(values).to.be.eql([new Buffer('hey')])
+          expect(values).to.be.eql([Buffer.from('hey')])
 
           listener.close(done)
         })
@@ -198,8 +202,8 @@ describe('dial', () => {
     })
   })
 
+  // TODO: figure out why is this failing
   it.skip('dial and destroy on listener', (done) => {
-    // TODO: why is this failing
     let count = 0
     const closed = ++count === 2 ? finish() : null
 
@@ -223,6 +227,8 @@ describe('dial', () => {
   })
 
   it('dial and destroy on dialer', (done) => {
+    if (isCI) { return done() }
+
     let count = 0
     const destroyed = () => ++count === 2 ? finish() : null
 
@@ -254,7 +260,7 @@ describe('dial', () => {
       conn,
       pull.collect((err, res) => {
         expect(err).to.not.exist()
-        expect(res).to.be.eql([new Buffer('hey!')])
+        expect(res).to.be.eql([Buffer.from('hey!')])
         done()
       })
     )
@@ -273,8 +279,11 @@ describe('filter addrs', () => {
     const mh2 = multiaddr('/ip4/127.0.0.1/udp/9090')
     const mh3 = multiaddr('/ip4/127.0.0.1/tcp/9090/http')
     const mh4 = multiaddr('/ip4/127.0.0.1/tcp/9090/ipfs/Qmb6owHp6eaWArVbcJJbQSyifyJBttMMjYV76N2hMbf5Vw')
+    const mh5 = multiaddr('/ip4/127.0.0.1/tcp/9090/http/ipfs/Qmb6owHp6eaWArVbcJJbQSyifyJBttMMjYV76N2hMbf5Vw')
+    const mh6 = multiaddr('/ip4/127.0.0.1/tcp/9090/ipfs/Qmb6owHp6eaWArVbcJJbQSyifyJBttMMjYV76N2hMbf5Vw' +
+      '/p2p-circuit/ipfs/Qmb6owHp6eaWArVbcJJbQSyifyJBttMMjYV76N2hMbf5Vw')
 
-    const valid = tcp.filter([mh1, mh2, mh3, mh4])
+    const valid = tcp.filter([mh1, mh2, mh3, mh4, mh5, mh6])
     expect(valid.length).to.equal(2)
     expect(valid[0]).to.deep.equal(mh1)
     expect(valid[1]).to.deep.equal(mh4)
@@ -349,6 +358,7 @@ describe('valid Connection', () => {
       const conn = tcp.dial(ma)
 
       pull(conn, pull.onEnd(endHandler))
+
       function endHandler () {
         conn.getPeerInfo((err, peerInfo) => {
           expect(err).to.exist()
@@ -375,6 +385,7 @@ describe('valid Connection', () => {
       const conn = tcp.dial(ma)
 
       pull(conn, pull.onEnd(endHandler))
+
       function endHandler () {
         conn.setPeerInfo('arroz')
         conn.getPeerInfo((err, peerInfo) => {
@@ -420,7 +431,7 @@ describe('Connection wrap', () => {
       connWrap,
       pull.collect((err, chunks) => {
         expect(err).to.not.exist()
-        expect(chunks).to.be.eql([new Buffer('hey')])
+        expect(chunks).to.be.eql([Buffer.from('hey')])
 
         connWrap.getPeerInfo((err, peerInfo) => {
           expect(err).to.not.exist()
@@ -439,7 +450,7 @@ describe('Connection wrap', () => {
       connWrap,
       pull.collect((err, chunks) => {
         expect(err).to.not.exist()
-        expect(chunks).to.be.eql([new Buffer('hey')])
+        expect(chunks).to.be.eql([Buffer.from('hey')])
         done()
       })
     )
@@ -465,7 +476,7 @@ describe('Connection wrap', () => {
       connWrap,
       pull.collect((err, chunks) => {
         expect(err).to.not.exist()
-        expect(chunks).to.be.eql([new Buffer('hey')])
+        expect(chunks).to.be.eql([Buffer.from('hey')])
         done()
       })
     )
@@ -492,7 +503,7 @@ describe('Connection wrap', () => {
       connWrap3,
       pull.collect((err, chunks) => {
         expect(err).to.not.exist()
-        expect(chunks).to.be.eql([new Buffer('hey')])
+        expect(chunks).to.be.eql([Buffer.from('hey')])
         connWrap3.getPeerInfo((err, peerInfo) => {
           expect(err).to.not.exist()
           expect(peerInfo).to.equal('inner doll')