Merge pull request #41 from NodeFactoryIo/mpetrunic/disable-noise-pipes

Disable noise pipes
This commit is contained in:
Belma Gutlic 2020-03-04 11:06:30 +01:00 committed by GitHub
commit c1151213b4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 9 deletions

View File

@ -25,7 +25,7 @@ import {NOISE, Noise} from "libp2p-noise"
//custom noise configuration, pass it instead of NOISE instance
const noise = new Noise(privateKey, Buffer.alloc(), false);
const noise = new Noise(privateKey, Buffer.alloc(x));
const libp2p = new Libp2p({
modules: {
@ -35,7 +35,6 @@ const libp2p = new Libp2p({
```
Where parameters for Noise constructor are:
- *private key* - required parameter (32 bytes libp2p peer private key)
- *static Noise key* - (optional) existing private Noise static key
- *early data* - (optional) an early data payload to be sent in handshake messages

View File

@ -42,11 +42,11 @@ export class Noise implements INoiseConnection {
*
* @param staticNoiseKey x25519 private key, reuse for faster handshakes
* @param earlyData
* @param useNoisePipes enable IK handshake if initiator static key is known
*/
constructor(staticNoiseKey?: bytes, earlyData?: bytes, useNoisePipes = true) {
constructor(staticNoiseKey?: bytes, earlyData?: bytes) {
this.earlyData = earlyData || Buffer.alloc(0);
this.useNoisePipes = useNoisePipes;
//disabled until properly specked
this.useNoisePipes = false;
if (staticNoiseKey) {
const publicKey = x25519.publicKeyCreate(staticNoiseKey);

View File

@ -133,7 +133,7 @@ describe("Noise", () => {
}
});
it("should communicate through encrypted streams with noise pipes", async() => {
it.skip("should communicate through encrypted streams with noise pipes", async() => {
try {
const staticKeysInitiator = generateKeypair();
const noiseInit = new Noise(staticKeysInitiator.privateKey);
@ -167,7 +167,7 @@ describe("Noise", () => {
}
});
it("IK -> XX fallback: initiator has invalid remote static key", async() => {
it.skip("IK -> XX fallback: initiator has invalid remote static key", async() => {
try {
const staticKeysInitiator = generateKeypair();
const noiseInit = new Noise(staticKeysInitiator.privateKey);
@ -233,7 +233,7 @@ describe("Noise", () => {
}
});
it("Initiator starts with XX (pipes disabled), responder has enabled noise pipes", async() => {
it.skip("Initiator starts with XX (pipes disabled), responder has enabled noise pipes", async() => {
try {
const staticKeysInitiator = generateKeypair();
const noiseInit = new Noise(staticKeysInitiator.privateKey, undefined, false);
@ -268,7 +268,7 @@ describe("Noise", () => {
}
});
it("IK: responder has no remote static key", async() => {
it.skip("IK: responder has no remote static key", async() => {
try {
const staticKeysInitiator = generateKeypair();
const noiseInit = new Noise(staticKeysInitiator.privateKey);