fluencelabs/assemblyscript
1
0
Fork 0
mirror of https://github.com/fluencelabs/assemblyscript synced 2025-04-26 15:32:16 +00:00
Code Issues Projects Releases Wiki Activity

Fix lifetime issue with assert messages, see #623

Browse Source
This commit is contained in:
dcode 2019-06-04 03:06:11 +02:00
parent ba35a6df45
commit e80ca1034f
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/builtins.ts
View File

@ -3943,9 +3943,16 @@ export function compileAbort(
var abortInstance = program.abortInstance; var abortInstance = program.abortInstance;
if (!(abortInstance && compiler.compileFunction(abortInstance))) return module.unreachable(); if (!(abortInstance && compiler.compileFunction(abortInstance))) return module.unreachable();
var messageArg = message != null var messageArg: ExpressionRef;
? compiler.compileExpression(message, stringInstance.type, ContextualFlags.IMPLICIT) if (message !== null) {
: stringInstance.type.toNativeZero(module); // The message argument works much like an arm of an IF that does not become executed if the
// assertion succeeds respectively is only being computed if the program actually crashes.
// Hence, let's make it so that the autorelease is skipped at the end of the current block,
// essentially ignoring the message GC-wise. Doesn't matter anyway on a crash.
messageArg = compiler.compileExpression(message, stringInstance.type, ContextualFlags.IMPLICIT | ContextualFlags.SKIP_AUTORELEASE);
} else {
messageArg = stringInstance.type.toNativeZero(module);
}
var filenameArg = compiler.ensureStaticString(reportNode.range.source.normalizedPath); var filenameArg = compiler.ensureStaticString(reportNode.range.source.normalizedPath);