fluencelabs/assemblyscript
1
0
Fork 0
mirror of https://github.com/fluencelabs/assemblyscript synced 2025-06-18 17:31:29 +00:00
Code Issues Projects Releases Wiki Activity

Require exact type in instanceof basicType, fixes #493

Browse Source
This commit is contained in:
dcode
2019-02-21 02:09:06 +01:00
parent 6b495f71d0
commit 8d2194f045
4 changed files with 330 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
src/compiler.ts
View File

@ -6138,24 +6138,32 @@ export class Compiler extends DiagnosticEmitter {
// time of implementation, this seemed more useful because dynamic rhs expressions are not
// possible in AS anyway.
var expr = this.compileExpressionRetainType(expression.expression, this.options.usizeType, WrapMode.NONE);
var type = this.currentType;
var isType = this.resolver.resolveType(
var actualType = this.currentType;
var expectedType = this.resolver.resolveType(
expression.isType,
this.currentFlow.actualFunction
);
this.currentType = Type.bool;
if (!isType) return module.createUnreachable();
return type.is(TypeFlags.NULLABLE) && !isType.is(TypeFlags.NULLABLE)
? type.nonNullableType.isAssignableTo(isType)
? module.createBinary( // not precomputeable
type.is(TypeFlags.LONG)
? BinaryOp.NeI64
: BinaryOp.NeI32,
expr,
type.toNativeZero(module)
)
: module.createI32(0)
: module.createI32(type.isAssignableTo(isType, true) ? 1 : 0);
if (!expectedType) return module.createUnreachable();
// instanceof <basicType> must be exact
if (!expectedType.is(TypeFlags.REFERENCE)) {
return module.createI32(actualType == expectedType ? 1 : 0);
}
// <nullable> instanceof <nonNullable> must be != 0
if (
actualType.is(TypeFlags.NULLABLE) && !expectedType.is(TypeFlags.NULLABLE) &&
actualType.nonNullableType.isAssignableTo(expectedType)
) {
return module.createBinary(
actualType.is(TypeFlags.LONG)
? BinaryOp.NeI64
: BinaryOp.NeI32,
expr,
actualType.toNativeZero(module)
);
}
return module.createI32(actualType.isAssignableTo(expectedType) ? 1 : 0);
}
compileLiteralExpression(