fluencelabs/assemblyscript
1
0
Fork 0
mirror of https://github.com/fluencelabs/assemblyscript synced 2025-04-26 23:42:15 +00:00
Code Issues Projects Releases Wiki Activity

add a note on acyclic detection

Browse Source
This commit is contained in:
dcode 2019-04-08 04:18:13 +02:00
parent c3ff3f2376
commit 6f25642601
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/program.ts
View File

@ -3259,6 +3259,16 @@ export class Class extends TypedElement {
/** Tests if this class potentially forms a reference cycle to another one. */ /** Tests if this class potentially forms a reference cycle to another one. */
private cyclesTo(other: Class, except: Set<Class> = new Set()): bool { private cyclesTo(other: Class, except: Set<Class> = new Set()): bool {
// TODO: The pure RC paper describes acyclic data structures as classes that may contain
//
// - scalars
// - references to classes that are both acyclic and final (here: Java); and
// - arrays (in our case: also sets, maps) of either of the above
//
// Our implementation, however, treats all objects that do not reference themselves directly
// or indirectly as acylic, allowing them to contain inner cycles of other non-acyclic objects.
// This contradicts the second assumption and must be revisited when actually implementing RC.
if (except.has(this)) return false; if (except.has(this)) return false;
except.add(this); // don't recurse indefinitely except.add(this); // don't recurse indefinitely