diff --git a/std/assembly/dataview.ts b/std/assembly/dataview.ts index 0e65466f..12c8817d 100644 --- a/std/assembly/dataview.ts +++ b/std/assembly/dataview.ts @@ -1,189 +1,200 @@ -import { - HEADER_SIZE, - MAX_BLENGTH -} from "./internal/arraybuffer"; +import { ArrayBuffer } from "./arraybuffer"; export class DataView { + private data: ArrayBuffer; + private dataStart: usize; + private dataEnd: usize; + constructor( - readonly buffer: ArrayBuffer, - readonly byteOffset: i32 = 0, - readonly byteLength: i32 = i32.MIN_VALUE // FIXME + buffer: ArrayBuffer, + byteOffset: i32 = 0, + byteLength: i32 = i32.MIN_VALUE // FIXME ) { if (byteLength === i32.MIN_VALUE) byteLength = buffer.byteLength - byteOffset; // FIXME - if (byteOffset > MAX_BLENGTH) throw new RangeError("Invalid byteOffset"); - if (byteLength > MAX_BLENGTH) throw new RangeError("Invalid byteLength"); - if (byteOffset + byteLength > buffer.byteLength) throw new RangeError("Invalid length"); + if (byteLength > ArrayBuffer.MAX_BYTELENGTH) throw new RangeError("Invalid byteLength"); + if (byteOffset + byteLength > buffer.byteLength) throw new RangeError("Invalid length"); + this.data = buffer; // links + var dataStart = changetype(buffer) + byteOffset; + this.dataStart = dataStart; + this.dataEnd = dataStart + byteLength; + } + + get buffer(): ArrayBuffer { + return this.data; + } + + get byteOffset(): i32 { + return (this.dataStart - changetype(this.data)); + } + + get byteLength(): i32 { + return (this.dataEnd - this.dataStart); } getFloat32(byteOffset: i32, littleEndian: boolean = false): f32 { - checkOffset(byteOffset, 4, this.byteLength); + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset + 4 > this.dataEnd) throw new Error("Offset out of bounds"); return littleEndian - ? load(changetype(this.buffer) + this.byteOffset + byteOffset, HEADER_SIZE) + ? load(dataOffset) : reinterpret( bswap( - load(changetype(this.buffer) + this.byteOffset + byteOffset, HEADER_SIZE) + load(dataOffset) ) ); } getFloat64(byteOffset: i32, littleEndian: boolean = false): f64 { - checkOffset(byteOffset, 8, this.byteLength); + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset + 4 > this.dataEnd) throw new Error("Offset out of bounds"); return littleEndian - ? load(changetype(this.buffer) + this.byteOffset + byteOffset, HEADER_SIZE) + ? load(dataOffset) : reinterpret( - bswap( - load(changetype(this.buffer) + this.byteOffset + byteOffset, HEADER_SIZE) + bswap( + load(dataOffset) ) ); } getInt8(byteOffset: i32): i8 { - checkOffset(byteOffset, 1, this.byteLength); - return load(changetype(this.buffer) + this.byteOffset + byteOffset, HEADER_SIZE); + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset >= this.dataEnd) throw new Error("Offset out of bounds"); + return load(dataOffset); } getInt16(byteOffset: i32, littleEndian: boolean = false): i16 { - checkOffset(byteOffset, 2, this.byteLength); - var result: i16 = load(changetype(this.buffer) + this.byteOffset + byteOffset, HEADER_SIZE); + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset + 2 > this.dataEnd) throw new Error("Offset out of bounds"); + var result: i16 = load(dataOffset); return littleEndian ? result : bswap(result); } getInt32(byteOffset: i32, littleEndian: boolean = false): i32 { - checkOffset(byteOffset, 4, this.byteLength); - var result = load(changetype(this.buffer) + this.byteOffset + byteOffset, HEADER_SIZE); + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset + 4 > this.dataEnd) throw new Error("Offset out of bounds"); + var result: i32 = load(dataOffset); return littleEndian ? result : bswap(result); } getUint8(byteOffset: i32): u8 { - checkOffset(byteOffset, 1, this.byteLength); - return load(changetype(this.buffer) + this.byteOffset + byteOffset, HEADER_SIZE); + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset >= this.dataEnd) throw new Error("Offset out of bounds"); + return load(dataOffset); } getUint16(byteOffset: i32, littleEndian: boolean = false): u16 { - checkOffset(byteOffset, 2, this.byteLength); - var result: u16 = load(changetype(this.buffer) + this.byteOffset + byteOffset, HEADER_SIZE); + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset + 2 > this.dataEnd) throw new Error("Offset out of bounds"); + var result: u16 = load(dataOffset); return littleEndian ? result : bswap(result); } getUint32(byteOffset: i32, littleEndian: boolean = false): u32 { - checkOffset(byteOffset, 4, this.byteLength); - var result = load(changetype(this.buffer) + this.byteOffset + byteOffset, HEADER_SIZE); + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset + 2 > this.dataEnd) throw new Error("Offset out of bounds"); + var result: u32 = load(dataOffset); return littleEndian ? result : bswap(result); } setFloat32(byteOffset: i32, value: f32, littleEndian: boolean = false): void { - checkOffset(byteOffset, 4, this.byteLength); - if (littleEndian) { - store(changetype(this.buffer) + this.byteOffset + byteOffset, value, HEADER_SIZE); - } else { - store(changetype(this.buffer) + this.byteOffset + byteOffset, - bswap( - reinterpret(value) - ), - HEADER_SIZE - ); - } + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset + 4 > this.dataEnd) throw new Error("Offset out of bounds"); + if (littleEndian) store(dataOffset, value); + else store(dataOffset, bswap(reinterpret(value))); } setFloat64(byteOffset: i32, value: f64, littleEndian: boolean = false): void { - checkOffset(byteOffset, 8, this.byteLength); - if (littleEndian) { - store(changetype(this.buffer) + this.byteOffset + byteOffset, value, HEADER_SIZE); - } else { - store(changetype(this.buffer) + this.byteOffset + byteOffset, - bswap( - reinterpret(value) - ), - HEADER_SIZE - ); - } + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset + 4 > this.dataEnd) throw new Error("Offset out of bounds"); + if (littleEndian) store(dataOffset, value); + else store(dataOffset, bswap(reinterpret(value))); } setInt8(byteOffset: i32, value: i8): void { - checkOffset(byteOffset, 1, this.byteLength); - store(changetype(this.buffer) + this.byteOffset + byteOffset, value, HEADER_SIZE); + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset >= this.dataEnd) throw new Error("Offset out of bounds"); + store(dataOffset, value); } setInt16(byteOffset: i32, value: i16, littleEndian: boolean = false): void { - checkOffset(byteOffset, 2, this.byteLength); - store( - changetype(this.buffer) + this.byteOffset + byteOffset, - littleEndian ? value : bswap(value), - HEADER_SIZE - ); + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset + 2 > this.dataEnd) throw new Error("Offset out of bounds"); + store(dataOffset, littleEndian ? value : bswap(value)); } setInt32(byteOffset: i32, value: i32, littleEndian: boolean = false): void { - checkOffset(byteOffset, 4, this.byteLength); - store( - changetype(this.buffer) + this.byteOffset + byteOffset, - littleEndian ? value : bswap(value), - HEADER_SIZE - ); + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset + 4 > this.dataEnd) throw new Error("Offset out of bounds"); + store(dataOffset, littleEndian ? value : bswap(value)); } setUint8(byteOffset: i32, value: u8): void { - checkOffset(byteOffset, 1, this.byteLength); - store(changetype(this.buffer) + this.byteOffset + byteOffset, value, HEADER_SIZE); + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset >= this.dataEnd) throw new Error("Offset out of bounds"); + store(dataOffset, value); } setUint16(byteOffset: i32, value: u16, littleEndian: boolean = false): void { - checkOffset(byteOffset, 2, this.byteLength); - store( - changetype(this.buffer) + this.byteOffset + byteOffset, - littleEndian ? value : bswap(value), - HEADER_SIZE - ); + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset + 2 > this.dataEnd) throw new Error("Offset out of bounds"); + store(dataOffset, littleEndian ? value : bswap(value)); } setUint32(byteOffset: i32, value: u32, littleEndian: boolean = false): void { - checkOffset(byteOffset, 4, this.byteLength); - store( - changetype(this.buffer) + this.byteOffset + byteOffset, - littleEndian ? value : bswap(value), - HEADER_SIZE - ); + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset + 4 > this.dataEnd) throw new Error("Offset out of bounds"); + store(dataOffset, littleEndian ? value : bswap(value)); } // Non-standard additions that make sense in WebAssembly, but won't work in JS: getInt64(byteOffset: i32, littleEndian: boolean = false): i64 { - checkOffset(byteOffset, 8, this.byteLength); - var result = load(changetype(this.buffer) + this.byteOffset + byteOffset, HEADER_SIZE); + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset + 8 > this.dataEnd) throw new Error("Offset out of bounds"); + var result: i64 = load(dataOffset); return littleEndian ? result : bswap(result); } getUint64(byteOffset: i32, littleEndian: boolean = false): u64 { - checkOffset(byteOffset, 8, this.byteLength); - var result = load(changetype(this.buffer) + this.byteOffset + byteOffset, HEADER_SIZE); + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset + 8 > this.dataEnd) throw new Error("Offset out of bounds"); + var result = load(dataOffset); return littleEndian ? result : bswap(result); } setInt64(byteOffset: i32, value: i64, littleEndian: boolean = false): void { - checkOffset(byteOffset, 8, this.byteLength); - store( - changetype(this.buffer) + this.byteOffset + byteOffset, - littleEndian ? value : bswap(value), - HEADER_SIZE - ); + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset + 8 > this.dataEnd) throw new Error("Offset out of bounds"); + store(dataOffset, littleEndian ? value : bswap(value)); } setUint64(byteOffset: i32, value: u64, littleEndian: boolean = false): void { - checkOffset(byteOffset, 8, this.byteLength); - store( - changetype(this.buffer) + this.byteOffset + byteOffset, - littleEndian ? value : bswap(value), - HEADER_SIZE - ); + var dataStart = this.dataStart; + var dataOffset = dataStart + byteOffset; + if (dataOffset + 8 > this.dataEnd) throw new Error("Offset out of bounds"); + store(dataOffset, littleEndian ? value : bswap(value)); } toString(): string { return "[object DataView]"; } } - -@inline function checkOffset(byteOffset: i32, n: i32, byteLength: i32): void { - // n and byteLength must be known to be in bounds - if (byteOffset > MAX_BLENGTH || byteOffset + n > byteLength) throw new Error("Offset out of bounds"); -}